Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon][SvgIcon] Change default fontSize from default to medium #23950

Merged
merged 4 commits into from
Dec 12, 2020
Merged

[Icon][SvgIcon] Change default fontSize from default to medium #23950

merged 4 commits into from
Dec 12, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Dec 10, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • [Icon][SvgIcon] The default value of fontSize was changed from default to medium for consistency.
    In the unlikey event that you were using the value default, the prop can be removed:

    -<SvgIcon fontSize="default">icon-name</SvgIcon>
+<SvgIcon>icon-name</SvgIcon>

For #20012

Motivated by #14993

@mbrookes mbrookes added breaking change component: Icon The React component. component: SvgIcon The React component. labels Dec 10, 2020
@mbrookes mbrookes added this to the v5 milestone Dec 10, 2020
@mbrookes mbrookes mentioned this pull request Dec 10, 2020
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 10, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 94e24ef

@github-actions github-actions bot mentioned this pull request Dec 10, 2020
Closed
@mbrookes mbrookes mentioned this pull request Dec 11, 2020
Closed
@mbrookes mbrookes mentioned this pull request Dec 12, 2020
Merged
@mbrookes mbrookes merged commit 0eb481b into mui:next Dec 12, 2020
@mbrookes mbrookes deleted the icons-fontsize-medium branch December 12, 2020 12:25
@oliviertassinari oliviertassinari changed the title [Icons] Change default fontSize from default to medium [Icon][SvgIcon] Change default fontSize from default to medium Dec 13, 2020
@oliviertassinari oliviertassinari mentioned this pull request Dec 20, 2020
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: Icon The React component. component: SvgIcon The React component.
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @mui-pr-bot @oliviertassinari